Dan Kenigsberg has posted comments on this change. Change subject: setupNetworks: Fix incorrect mtu overriding when adding multiple networks ......................................................................
Patch Set 1: Code-Review-1 (1 comment) http://gerrit.ovirt.org/#/c/25343/1//COMMIT_MSG Commit Message: Line 12: be set. Line 13: Line 14: This was because the _netinfo object is passed from addNetworks to Line 15: addNetworks and the objectivize of the succeeding addNetworks would Line 16: not see the higher MTUs set by the preceding addNetworks. Was this introduced by the recent scaling work? Can you think of a functional test that could have revealed it earlier? (I'd expect testSetupNetworksMtus, but it missed the bug) Line 17: Line 18: Change-Id: Ia375c2e0e4a1896ab99d734e3203a5ef49570f36 Line 19: Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1072411 -- To view, visit http://gerrit.ovirt.org/25343 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia375c2e0e4a1896ab99d734e3203a5ef49570f36 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon <asegu...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Ondřej Svoboda <osvob...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
