Nir Soffer has posted comments on this change. Change subject: resourceManager: Keep resource state if registerResource fails ......................................................................
Patch Set 4: (1 comment) http://gerrit.ovirt.org/#/c/25284/4/tests/resourceManagerTests.py File tests/resourceManagerTests.py: Line 499: res1.release() Line 500: res2.release() Line 501: Line 502: def testAcquireResourceFailureExclusive(self): Line 503: self.assertAcquireResourceFails("string", "test", > i suggest to export those to constants and to use them in all methods, beca Good idea for another patch - this strings are used all over this file. Line 504: resourceManager.LockType.exclusive) Line 505: self.assertCanAcquireResource("string", "test") Line 506: Line 507: def testAcquireResourceFailureExclusiveShared(self): -- To view, visit http://gerrit.ovirt.org/25284 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I16abf41ebc8a8a99b292d38c945074752254a34b Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Antoni Segura Puimedon <asegu...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Daniel P. Berrange <berra...@redhat.com> Gerrit-Reviewer: Federico Simoncelli <fsimo...@redhat.com> Gerrit-Reviewer: Liron Ar <lara...@redhat.com> Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Saggi Mizrahi <smizr...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches