mooli tayer has posted comments on this change. Change subject: minor changes in passwd.py ......................................................................
Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/25489/1//COMMIT_MSG Commit Message: Line 5: CommitDate: 2014-03-06 16:35:48 +0200 Line 6: Line 7: minor changes in passwd.py Line 8: Line 9: Replace Exception with RuntimeError and singleton tuple with variable. > I don't mind the RuntimeError change, but doing I got the opposite review before: So I guess we need to pick one and I will apply to both patches http://gerrit.ovirt.org/#/c/21772/5..8/lib/vdsm/tool/passwd.py,cm Line 10: Line 11: Change-Id: I4ced7980e975e2cce588261812ecdb1847b5941f -- To view, visit http://gerrit.ovirt.org/25489 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4ced7980e975e2cce588261812ecdb1847b5941f Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: mooli tayer <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: mooli tayer <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
