Nir Soffer has posted comments on this change. Change subject: xmlrpc: Use correct base class for parsing request ......................................................................
Patch Set 2: (1 comment) http://gerrit.ovirt.org/#/c/25524/2//COMMIT_MSG Commit Message: Line 9: Previously we always used SecureXMLRPCServer.parse_request, even when Line 10: using SimpleXMLRPCServer. That happened to work since both inherit Line 11: parse_request from BaseHTTPServer. This patch use the correct base Line 12: class, so if one of them will override parse_request, we use the correct Line 13: method. Please add note that without this fix ssl=false does not work on python 2.7. This may be true also for python 2.6 but we need to verify this. Line 14: Line 15: Change-Id: I4ef737c02afb97580179f381e0f227ee94e1383f Line 16: Signed-off-by: Gustavo Pedrosa <[email protected]> -- To view, visit http://gerrit.ovirt.org/25524 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4ef737c02afb97580179f381e0f227ee94e1383f Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.4 Gerrit-Owner: Gustavo Frederico Temple Pedrosa <[email protected]> Gerrit-Reviewer: Gustavo Frederico Temple Pedrosa <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
