Yaniv Bronhaim has posted comments on this change. Change subject: Adding remove/disable verbs to vdsm-tool for admin usages ......................................................................
Patch Set 9: (1 comment) one last nit http://gerrit.ovirt.org/#/c/21772/9/lib/vdsm/tool/configurator.py File lib/vdsm/tool/configurator.py: Line 31: Line 32: P_SYSTEMCTL_CONF = SYSCONF_PATH + '/sysctl.d/vdsm' Line 33: P_VDSM_LCONF = SYSCONF_PATH + '/libvirt/libvirtd.conf' Line 34: P_VDSM_LDCONF = SYSCONF_PATH + '/sysconfig/libvirtd' Line 35: P_VDSM_QCONF = SYSCONF_PATH + '/libvirt/qemu.conf' its only used in LibvirtModuleConfigure, put it there. SYSCONF_PATH refers to /etc/ , I prefer to leave the constants.py file, abandon the SYCONF_PATH, and declare the full path here Line 36: Line 37: def removeSectionFromFile(filename, beginField=None, endField=None): Line 38: ( Line 39: BEFORE, -- To view, visit http://gerrit.ovirt.org/21772 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie7f2c031436a6d202f856c24d9c9420c8bfdf6df Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: mooli tayer <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
