Tal Nisan has posted comments on this change. Change subject: Allow getFileStats for non NFS ISO domains ......................................................................
Patch Set 1: (3 comments) http://gerrit.ovirt.org/#/c/25627/1//COMMIT_MSG Commit Message: Line 5: CommitDate: 2014-03-11 18:20:14 +0200 Line 6: Line 7: Allow getFileStats for non NFS ISO domains Line 8: Line 9: getFileStats only allowed file stats to be gathered for NFS ISO domains > s/for/from/ Done Line 10: we currently support ISO domains of different storage types so the check Line 11: was corrected. Line 12: Line 13: Change-Id: I7107d20b1b8b341086800bb35def895a70c4b4f0 Line 6: Line 7: Allow getFileStats for non NFS ISO domains Line 8: Line 9: getFileStats only allowed file stats to be gathered for NFS ISO domains Line 10: we currently support ISO domains of different storage types so the check > s/of different storage types/on any file storage domain/ Done Line 11: was corrected. Line 12: Line 13: Change-Id: I7107d20b1b8b341086800bb35def895a70c4b4f0 Line 14: Signed-off-by: Tal Nisan <[email protected]> http://gerrit.ovirt.org/#/c/25627/1/vdsm/storage/hsm.py File vdsm/storage/hsm.py: Line 2230: vars.task.setDefaultException(se.GetFileStatsError(sdUUID)) Line 2231: vars.task.getSharedLock(STORAGE, sdUUID) Line 2232: Line 2233: dom = sdCache.produce(sdUUID=sdUUID) Line 2234: if not dom.isISO: > To avoid the use of this on block domains (impossible) we may want to keep In that case I reckon that there will never be an ISO domain which is a block domains so isISO should never return true, but I added the check anyway Line 2235: raise se.GetFileStatsError(sdUUID) Line 2236: Line 2237: fileStats = dom.getFileList(pattern=pattern, Line 2238: caseSensitive=caseSensitive) -- To view, visit http://gerrit.ovirt.org/25627 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7107d20b1b8b341086800bb35def895a70c4b4f0 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Tal Nisan <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Tal Nisan <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
