Dan Kenigsberg has submitted this change and it was merged. Change subject: Avoid to recompile namedtuple ATTR classes in lvm. ......................................................................
Avoid to recompile namedtuple ATTR classes in lvm. Re-defining the ??_ATTR classes may be hurting the performance during the VM creation (preliminary). This patch avoids attribute class creation each time the lvm object is recreated. Should be noted that re-creating lvm cached objects during the VM creation is not required, therefore paths modified by the actual patch should not be called in such scenario. This abnormal situation will be corrected in a following patch. Dealing with variable attribute strings is not required for the actual development of oVirt and the lvm module, then _attr2NamedTuple() can be removed. Change-Id: I66110a7f25fb5cfd80ddffe9a22e1cbac11de447 Signed-off-by: Eduardo <[email protected]> Reviewed-on: http://gerrit.ovirt.org/25678 Tested-by: Meital bourvine <[email protected]> Reviewed-by: Antoni Segura Puimedon <[email protected]> Reviewed-by: Yeela Kaplan <[email protected]> Reviewed-by: Francesco Romani <[email protected]> Reviewed-by: Saggi Mizrahi <[email protected]> Reviewed-by: Dan Kenigsberg <[email protected]> --- M vdsm/storage/lvm.py 1 file changed, 9 insertions(+), 17 deletions(-) Approvals: Yeela Kaplan: Looks good to me, but someone else must approve Saggi Mizrahi: Looks good to me, but someone else must approve Antoni Segura Puimedon: Looks good to me, but someone else must approve Dan Kenigsberg: Looks good to me, approved Meital bourvine: Verified Francesco Romani: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/25678 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I66110a7f25fb5cfd80ddffe9a22e1cbac11de447 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Eduardo <[email protected]> Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]> Gerrit-Reviewer: Barak Azulay <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Eduardo <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Itamar Heim <[email protected]> Gerrit-Reviewer: Meital Bourvine <[email protected]> Gerrit-Reviewer: Meital bourvine <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Saggi Mizrahi <[email protected]> Gerrit-Reviewer: Yeela Kaplan <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
