Douglas Schilling Landgraf has posted comments on this change. Change subject: Add vdsm/ut directory to the tarball ......................................................................
Patch Set 1: Code-Review-1 (1 comment) -1 for now, please see my comment. Thanks for the catch and patch. http://gerrit.ovirt.org/#/c/25861/1/vdsm/ut/Makefile.am File vdsm/ut/Makefile.am: Hello Kiril, - Please include header copyright A quick look of Makefiles.am, seems we are using EXTRA_DIST for .in files. You could try the below approach: <Header copyright> include $(top_srcdir)/build-aux/Makefile.subs vdsmutdir = $(vdsmdir)/ut dist_vdsmut_PYTHON = \ ivdsm.py \ $(NULL) Line 1: EXTRA_DIST = \ Line 2: ivdsm.py \ -- To view, visit http://gerrit.ovirt.org/25861 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I39fa49887de601bbb4ee605ef2da6a0a69809a66 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Kiril Nesenko <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Douglas Schilling Landgraf <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Kiril Nesenko <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
