Nir Soffer has posted comments on this change. Change subject: clientIF: prepareVolumePath payload cleanup ......................................................................
Patch Set 4: (1 comment) And the helper function name got worse. http://gerrit.ovirt.org/#/c/24636/4/vdsm/clientIF.py File vdsm/clientIF.py: Line 321: Line 322: self.log.info("prepared volume path: %s", volPath) Line 323: return volPath Line 324: Line 325: def _makePayloadVolume(self, vmId, device, payload): This name is worse than the previous name: _prepareVolumeFromPayload. Are you creating a payload volume? Since this function is called from prepareVolumePath when preparing from a payload, the name should be _prepareVolumePathFromPayload. If you have trouble with pep8, you can indent the arguments like this: volPath = self._prepareVolumePathFromPayload(vmId, device, payload) Line 326: """ Line 327: param vmId: Line 328: VM UUID or None Line 329: param device: -- To view, visit http://gerrit.ovirt.org/24636 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I058206b7506ddbb5ec087c9ea0963a10ed57affb Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Eduardo <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Martin Polednik <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Vinzenz Feenstra <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
