Nir Soffer has posted comments on this change. Change subject: Introduction for caching the parsed domain XML ......................................................................
Patch Set 13: (1 comment) http://gerrit.ovirt.org/#/c/17694/13/vdsm/vm.py File vdsm/vm.py: Line 3105: self._getUnderlyingWatchdogDeviceInfo() Line 3106: self._getUnderlyingSmartcardDeviceInfo() Line 3107: self._getUnderlyingConsoleDeviceInfo() Line 3108: # Obtain info of all unknown devices. Must be last! Line 3109: self._getUnderlyingUnknownDeviceInfo() For another patch: get rid of the "Underlying" in these names. Line 3110: Line 3111: def _updateAgentChannels(self): Line 3112: """ Line 3113: We moved the naming of guest agent channel sockets. To keep backwards -- To view, visit http://gerrit.ovirt.org/17694 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7e106b2f2d3f4160d4e882f1a2880cb1b52fbb22 Gerrit-PatchSet: 13 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Vinzenz Feenstra <[email protected]> Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Itamar Heim <[email protected]> Gerrit-Reviewer: Martin Sivák <[email protected]> Gerrit-Reviewer: Michal Skrivanek <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Peter V. Saveliev <[email protected]> Gerrit-Reviewer: Vinzenz Feenstra <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
