Dan Kenigsberg has submitted this change and it was merged. Change subject: vdsm: Add ACPI support for VM shutdown/reboot ......................................................................
vdsm: Add ACPI support for VM shutdown/reboot Refactored the existing shutdown/reboot code to utilize the utils.CallbackChain helper. Extracted existing code to new module vmCommands.py and split into following classes: VmPowerDown - base class handling CallbackChain functionality |-- VmShutdown - shutdown specific callbacks `-- VmReboot - reboot specific callbacks Both power-down commands now try first guestAgent (if available) and if given power-down action hasn't succeeded in given `timeout` ACPI variant will be tried (again if available). Change-Id: I8cc4f4140913df9827cca296e880b37f47a21b76 Signed-off-by: Martin Betak <mbe...@redhat.com> Reviewed-on: http://gerrit.ovirt.org/23457 Reviewed-by: Antoni Segura Puimedon <asegu...@redhat.com> Reviewed-by: Dan Kenigsberg <dan...@redhat.com> --- M debian/vdsm.install M vdsm.spec.in M vdsm/Makefile.am M vdsm/vm.py A vdsm/vmpowerdown.py 5 files changed, 124 insertions(+), 55 deletions(-) Approvals: Antoni Segura Puimedon: Looks good to me, but someone else must approve Martin Betak: Verified Dan Kenigsberg: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/23457 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8cc4f4140913df9827cca296e880b37f47a21b76 Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Betak <mbe...@redhat.com> Gerrit-Reviewer: Antoni Segura Puimedon <asegu...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Martin Betak <mbe...@redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skriva...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches