Dan Kenigsberg has posted comments on this change. Change subject: tools: configurator must persist usermod changes ......................................................................
Patch Set 4: (1 comment) http://gerrit.ovirt.org/#/c/25974/4//COMMIT_MSG Commit Message: Line 7: tools: configurator must persist usermod changes Line 8: Line 9: vdsm-tool configure --force adds to /etc/group (qemu/kvm) sanlock Line 10: but doesn't persist the file in ovirt node distro which will Line 11: affect vdsm start on next reboot. The goal for this patch is persist > it was in %pre. we moved it to configurator to centralized all services' co One bit of ugliness in the current state is that we do not remove vdsm group from sanlock when vdsm is removed. Each configurator should probably have an "unconfigure" method to be called upon %preun. But that's an issue for another patch. How about calling vdsm-tool -m sanlock configure in %post ? Line 12: the /etc/group in case vdsm-tool is running on ovirt-node. Line 13: Line 14: Change-Id: Id4a7dea08bac41ff557aa52826463f2bdf481562 -- To view, visit http://gerrit.ovirt.org/25974 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id4a7dea08bac41ff557aa52826463f2bdf481562 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf <dougsl...@redhat.com> Gerrit-Reviewer: Barak Azulay <bazu...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Douglas Schilling Landgraf <dougsl...@redhat.com> Gerrit-Reviewer: Fabian Deutsch <fabi...@fedoraproject.org> Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
