Dan Kenigsberg has posted comments on this change. Change subject: vm: handle missing domains on recovery ......................................................................
Patch Set 1: -Code-Review (1 comment) http://gerrit.ovirt.org/#/c/25275/1//COMMIT_MSG Commit Message: Line 7: vm: handle missing domains on recovery Line 8: Line 9: When VDSM tries to reconnect to libvirt, it is possible Line 10: that the domain lookup fails. This is especially true on Line 11: recovering. Sorry for being a bit slow here, but we should already have a safeguard in place: Vdsm should not even try to recover VMs before it holds a libvirt connection, and it should be taken down if the connection is broken while recovering. Please explain better why we need this, and why it has to be the basis of the follow-up patch. Line 12: Line 13: This patch add an explicit check in the recovery path to Line 14: make sure that a VM is either created with a valid libvirt Line 15: domain handle, or it is reported as Down so the engine -- To view, visit http://gerrit.ovirt.org/25275 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I00ef12883c8035209de0f273925eb8603d6b6da8 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Michal Skrivanek <[email protected]> Gerrit-Reviewer: Vinzenz Feenstra <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
