Francesco Romani has posted comments on this change. Change subject: recovery: try to restore VMs from recovery files ......................................................................
Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/25276/1/vdsm/clientIF.py File vdsm/clientIF.py: Line 419: # we do this to safely handle VMs which disappeared Line 420: # from the host while VDSM was down/restarting Line 421: for vmId in self._getVDSMVmsFromRecovery(): Line 422: if not self._recoverVm(vmId): Line 423: self.log.info('expected VM %s from recovery file but' > Where is a new VM object created and added to vmContainer in Down state? the VM object will be added by clientIF.createVm (see line 380) which is in turn called by clientIF._recoverVm (line 522). The Down state will be a result of trying to recover a Vm from a recovery file without a libvirt connection. The change http://gerrit.ovirt.org/#/c/25275/ will catch those situations and force the VM object to Down. Line 424: 'missing, reported as Down', vmId) Line 425: Line 426: while (self._enabled and Line 427: 'WaitForLaunch' in [v.lastStatus for v in -- To view, visit http://gerrit.ovirt.org/25276 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id495f6047ba658c2b04da19bd7bf76425b3b9659 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Michal Skrivanek <[email protected]> Gerrit-Reviewer: Vinzenz Feenstra <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
