Vinzenz Feenstra has posted comments on this change. Change subject: Create GuestAgent instance in __init__ and connect later ......................................................................
Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/26142/1//COMMIT_MSG Commit Message: Line 8: Line 9: This is not only a cosmetic improvement. There are cases where we Line 10: are trying to call methods of the GuestAgent before the instance was Line 11: created. To avoid these race conditions we're creating the instance of Line 12: the guest agent already in the __init__ phase. > Makes sense to me and looks like an improvement, but, not being so much fam Well most of them swallow everything at the moment. And we can make it swallow even more of those things if necessary. Not connected is not such an uncommon thing, unfortunately. At least nowadays Line 13: Line 14: Change-Id: I82f7397b01bff48a3c635eee9912cc67cf722b13 -- To view, visit http://gerrit.ovirt.org/26142 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I82f7397b01bff48a3c635eee9912cc67cf722b13 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Vinzenz Feenstra <vfeen...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Vinzenz Feenstra <vfeen...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
