Yaniv Bronhaim has posted comments on this change. Change subject: util: fix execCmd to accept tuples ......................................................................
Patch Set 4: (1 comment) http://gerrit.ovirt.org/#/c/26070/4/tests/utilsTests.py File tests/utilsTests.py: Line 464: Line 465: class patchedCPopen(cpopen.CPopen): Line 466: def __init__(self, proc_args, *args, **kwargs): Line 467: ExecCmdTest.origCPopen.__init__(self, proc_args, *args, **kwargs) Line 468: self.command = proc_args write short comment why you do that . will be simpler. its a test, you don't really want to follow the code, just understand it as fast as possible (imo..) Line 469: Line 470: def __init__(self, *args, **kwargs): Line 471: TestCaseBase.__init__(self, *args, **kwargs) Line 472: -- To view, visit http://gerrit.ovirt.org/26070 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8d1269d9a26b1fef1552976ae626cf4596471283 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dima Kuznetsov <dkuzn...@redhat.com> Gerrit-Reviewer: Antoni Segura Puimedon <asegu...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Saggi Mizrahi <smizr...@redhat.com> Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches