Antoni Segura Puimedon has posted comments on this change. Change subject: network: Introduce the network package ......................................................................
Patch Set 2: Code-Review-1 (3 comments) http://gerrit.ovirt.org/#/c/25908/2/configure.ac File configure.ac: Line 268: vdsm-tool/Makefile Line 269: vdsm/Makefile Line 270: vdsm/gluster/Makefile Line 271: vdsm/network/configurators/Makefile Line 272: vdsm/network/Makefile Swap these two lines. Line 273: vdsm/sos/Makefile Line 274: vdsm/storage/Makefile Line 275: vdsm/storage/imageRepository/Makefile Line 276: vdsm/storage/protect/Makefile http://gerrit.ovirt.org/#/c/25908/2/vdsm/API.py File vdsm/API.py: Line 1: # Line 2: # Copyright (C) 2012-2014 Adam Litke, IBM Corporation 2012-2014 Red Hat. Line 3: # Line 4: # This program is free software; you can redistribute it and/or modify Line 5: # it under the terms of the GNU General Public License as published by Line 6: # the Free Software Foundation; either version 2 of the License, or http://gerrit.ovirt.org/#/c/25908/2/vdsm/network/configurators/dhclient.py File vdsm/network/configurators/dhclient.py: Line 1: # Copyright (C) 2013-2014, IBM Corporation 2014 Red Hat Line 2: # Line 3: # This program is free software; you can redistribute it and/or modify Line 4: # it under the terms of the GNU General Public License as published by Line 5: # the Free Software Foundation; either version 2 of the License, or -- To view, visit http://gerrit.ovirt.org/25908 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I532c179d4002ed1e8e5445d02297c8d5a6248647 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon <[email protected]> Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]> Gerrit-Reviewer: Assaf Muller <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Vinzenz Feenstra <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
