Nir Soffer has posted comments on this change. Change subject: core: Add boot time to the getVdsStats API ......................................................................
Patch Set 6: (1 comment) http://gerrit.ovirt.org/#/c/25877/6/tests/samplingTests.py File tests/samplingTests.py: Line 60: os.remove(path) Line 61: Line 62: def testBootTimeEmpty(self): Line 63: with self.assertRaises(IndexError): Line 64: sampling.getBootTime('/dev/null') This test document the wrong error handling in this code. Does it make sense that getBootTime raise an IndexError? This error is just a side effect of the current implementation, and should not be part of the api. Line 65: Line 66: def testBootTimeMalformed(self): Line 67: (f, path) = tempfile.mkstemp() Line 68: os.write(f, self.boot_time_fixture_bad) -- To view, visit http://gerrit.ovirt.org/25877 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I319e619cdaecac2f86d0154e3adbb3beda9c57d6 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dima Kuznetsov <dkuzn...@redhat.com> Gerrit-Reviewer: Adam Litke <ali...@redhat.com> Gerrit-Reviewer: Antoni Segura Puimedon <asegu...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Douglas Schilling Landgraf <dougsl...@redhat.com> Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Saggi Mizrahi <smizr...@redhat.com> Gerrit-Reviewer: Tal Nisan <tni...@redhat.com> Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
