Antoni Segura Puimedon has posted comments on this change. Change subject: virt: migration: merge monitor and downtime thread ......................................................................
Patch Set 8: Code-Review-1 (2 comments) some more small comments http://gerrit.ovirt.org/#/c/25977/8/vdsm/virt/migration.py File vdsm/virt/migration.py: Line 356: self._progressTimeout = config.getint('vars', Line 357: 'migrationprogressTimeout') Line 358: Line 359: self._downtime = downTime Line 360: delayPerGiB = config.getint('vars', 'migration_downtime_delay') I'd make this a constant. Line 361: self._wait = (delayPerGiB * max(memSize, 2048) + 1023) / 1024 Line 362: self._downtimeInterval = self._wait / self.DOWNTIME_STEPS Line 363: self._downtimeStep = 0 Line 364: Line 440: def update_downtime(self, i): Line 441: return self._downtime * (i + 1) / self.DOWNTIME_STEPS Line 442: Line 443: def monitor_downtime(self, step): Line 444: if self._downtimeStep < self.DOWNTIME_STEPS and \ prefer parenthesis to escaping line breaks. Line 445: step % self._downtimeInterval == 0: Line 446: downtime = self.update_downtime(self._downtimeStep) Line 447: self._vm.log.debug('setting migration downtime to %d', downtime) Line 448: self._vm._dom.migrateSetMaxDowntime(downtime, 0) -- To view, visit http://gerrit.ovirt.org/25977 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7ac66331b44435a9cffeb9de1454db6843245979 Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Antoni Segura Puimedon <asegu...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches