Dan Kenigsberg has submitted this change and it was merged. Change subject: utils: Optimize namedtuple definition in pidStat ......................................................................
utils: Optimize namedtuple definition in pidStat Profiling idle vdsm reveal that 60% of cpu time is spent in creating pointless namedtuples. In particular, 823 calls were made in 4.88 seconds of cpu time, invoking collections.py genexpr function 296805 times. This patch creates the one and only namedtuple needed by pidStat when the module is imported. Change-Id: Ic5841b338cc0e9376c3bd7815206c27829c286d6 Signed-off-by: Nir Soffer <[email protected]> Reviewed-on: http://gerrit.ovirt.org/26097 Reviewed-by: Yaniv Bronhaim <[email protected]> Reviewed-by: Dan Kenigsberg <[email protected]> Reviewed-by: Francesco Romani <[email protected]> Reviewed-by: Antoni Segura Puimedon <[email protected]> --- M lib/vdsm/utils.py 1 file changed, 14 insertions(+), 12 deletions(-) Approvals: Nir Soffer: Verified Yaniv Bronhaim: Looks good to me, but someone else must approve Antoni Segura Puimedon: Looks good to me, but someone else must approve Dan Kenigsberg: Looks good to me, approved Francesco Romani: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/26097 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic5841b338cc0e9376c3bd7815206c27829c286d6 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
