Dan Kenigsberg has posted comments on this change.

Change subject: lvm: Disable usage of lv_metad daemon
......................................................................


Patch Set 1: Code-Review-1

(1 comment)

Please fix commit message to alleviate worries

http://gerrit.ovirt.org/#/c/25408/1//COMMIT_MSG
Commit Message:

Line 7: lvm: Disable usage of lv_metad daemon
Line 8: 
Line 9: On current Fedora lvm version, lvm uses the lvmetad daemon, which cause
Line 10: some vdsm lvm queries to return incorrect data. This patch uses vdsm
Line 11: private configuration to disable usage of lvmetad.
I don't claim to understand the issue, but the following line in in lvm.conf(5) 
seems ominous, and suggests that we may need to either integrate with lvmetad 
or conflict with its running:

 If lvmetad has been running while use_lvmetad was 0, 
 it  MUST  be  stopped before changing use_lvmetad to 1
 and started again afterwards.
Line 12: 
Line 13: Change-Id: I909f03a2abada97e08cb9c645e357aa80ef9d788


-- 
To view, visit http://gerrit.ovirt.org/25408
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I909f03a2abada97e08cb9c645e357aa80ef9d788
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Douglas Schilling Landgraf <[email protected]>
Gerrit-Reviewer: Eduardo <[email protected]>
Gerrit-Reviewer: Federico Simoncelli <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Mark Wu <[email protected]>
Gerrit-Reviewer: Nir Soffer <[email protected]>
Gerrit-Reviewer: Saggi Mizrahi <[email protected]>
Gerrit-Reviewer: [email protected]
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Reply via email to