Dan Kenigsberg has posted comments on this change. Change subject: guest: Add support for guest cpu topology ......................................................................
Patch Set 15: Code-Review-1 (2 comments) Making Federico's question more visible, and adding my own questions. http://gerrit.ovirt.org/#/c/23258/15/vdsm_api/vdsmapi-schema.json File vdsm_api/vdsmapi-schema.json: Line 5825: # Line 5826: # @online: Range of CPUs that are online and being scheduled Line 5827: # Format: '1-2,4,9-31' Line 5828: # Line 5829: # @offline: Range of CPUs that are not online because they have been why do we want to report both "online" and "offline"? it seems like the are complementary. Line 5830: # HOTPLUGGED off or exceed the limit of CPUs allowed by the Line 5831: # kernel configuration. (See `possible` value) Line 5832: # Format: '0,3,5-8' Line 5833: # Line 5834: # @present: Range of CPUs that have been identified as being present in Line 5835: # the system. Format: '0-31' Line 5836: # Line 5837: # @possible: Range of CPUs that have been allocated resources and can be Line 5838: # brought online if they are present. Format: '0-127' I don't quite understand this state. Is there a standalone documentation of it? Could you point to it in the commit message? Line 5839: # Line 5840: # Line 5841: # Since: 4.14.0 Line 5842: ## -- To view, visit http://gerrit.ovirt.org/23258 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I827ab095ee9270faf27f44e91c7bc998e133351e Gerrit-PatchSet: 15 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Vinzenz Feenstra <[email protected]> Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Douglas Schilling Landgraf <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Michal Skrivanek <[email protected]> Gerrit-Reviewer: Roy Golan <[email protected]> Gerrit-Reviewer: Vinzenz Feenstra <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
