Dima Kuznetsov has posted comments on this change. Change subject: util: fix execCmd to accept tuples ......................................................................
Patch Set 5: (1 comment) http://gerrit.ovirt.org/#/c/26070/5/lib/vdsm/utils.py File lib/vdsm/utils.py: Line 674: if sudo: Line 675: if os.geteuid() != 0: Line 676: command = [constants.EXT_SUDO, SUDO_NON_INTERACTIVE_FLAG] + command Line 677: Line 678: command = tuple(command) > Now I see that it was added - I probably should invest more time before I w Forgot to take it down Line 679: if not printable: Line 680: printable = command Line 681: Line 682: cmdline = repr(subprocess.list2cmdline(printable)) -- To view, visit http://gerrit.ovirt.org/26070 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8d1269d9a26b1fef1552976ae626cf4596471283 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dima Kuznetsov <dkuzn...@redhat.com> Gerrit-Reviewer: Antoni Segura Puimedon <asegu...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Dima Kuznetsov <dkuzn...@redhat.com> Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Saggi Mizrahi <smizr...@redhat.com> Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
