Francesco Romani has posted comments on this change. Change subject: virt: migration: move threads in a separate module ......................................................................
Patch Set 8: (1 comment) http://gerrit.ovirt.org/#/c/25970/8/vdsm/virt/migration.py File vdsm/virt/migration.py: Line 29: from vdsm import vdscli Line 30: from vdsm.compat import pickle Line 31: from vdsm.config import config Line 32: from vdsm.define import NORMAL, errCode, Mbytes Line 33: from . import vmexitreason > I suggest (not necessarily done in this patch) to put the in package import Done Line 34: Line 35: Line 36: class MigrationSourceThread(threading.Thread): Line 37: """ -- To view, visit http://gerrit.ovirt.org/25970 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia69c7448b66417c7bba8ae3d301e7d777ca88067 Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Antoni Segura Puimedon <asegu...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Federico Simoncelli <fsimo...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skriva...@redhat.com> Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Vinzenz Feenstra <vfeen...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
