Liron Ar has uploaded a new change for review. Change subject: core: fixing attribute error on fenceSpmStorage ......................................................................
core: fixing attribute error on fenceSpmStorage In change I75493d1db60e51cccd5231b516f963c970d24c99 the pool metadata operations were moved to the pool backend, while the call to invalidateMetadata in fenceSpmStorage was left as it was, leading to an attribute error. This patch fixes it by checking the backend type before executing it, though it's not the nicest way for doing so, it's the pattern already being used in other places in hsm.py,therefore in the meanwhile it can be fixed the same way. Change-Id: I48bb2211c6e62d1589f1a56616df105c52654344 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1082365 Signed-off-by: Liron Aravot <lara...@redhat.com> --- M vdsm/storage/hsm.py 1 file changed, 2 insertions(+), 1 deletion(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/57/26357/1 diff --git a/vdsm/storage/hsm.py b/vdsm/storage/hsm.py index 0ebe129..d9697ef 100644 --- a/vdsm/storage/hsm.py +++ b/vdsm/storage/hsm.py @@ -3529,7 +3529,8 @@ se.SpmFenceError("spUUID=%s, lastOwner=%s, lastLver=%s" % (spUUID, lastOwner, lastLver))) pool = self.getPool(spUUID) - pool.invalidateMetadata() + if isinstance(pool.getBackend(), StoragePoolDiskBackend): + pool.getBackend().invalidateMetadata() vars.task.getExclusiveLock(STORAGE, spUUID) pool.forceFreeSpm() return dict(spm_st=self._getSpmStatusInfo(pool)) -- To view, visit http://gerrit.ovirt.org/26357 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I48bb2211c6e62d1589f1a56616df105c52654344 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Liron Ar <lara...@redhat.com> _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
