Francesco Romani has posted comments on this change. Change subject: vm: add boot menu support ......................................................................
Patch Set 3: Verified+1 Patch set 3: * rebased (needed changes, so no trivial rebase, +1/+2 lost :( ) * added explicit boolean cast to prevent a corner case, being the 'bootMenuEnable' parameter being present but falsy * verified manually using vdsClient and inspecting the XML on the logs looking for the presence of the `bootmenu` attribute * unit tests still works -- To view, visit http://gerrit.ovirt.org/23558 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4a845097294603bbb11e7941995cb1729f388109 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Martin Betak <[email protected]> Gerrit-Reviewer: Martin Polednik <[email protected]> Gerrit-Reviewer: Michal Skrivanek <[email protected]> Gerrit-Reviewer: Vinzenz Feenstra <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
