Ondřej Svoboda has posted comments on this change. Change subject: network: Reset bonding options we did not modify to defaults (WIP) ......................................................................
Patch Set 6: (2 comments) Comments on the dictionary of defaults. http://gerrit.ovirt.org/#/c/26374/6//COMMIT_MSG Commit Message: Line 6: Line 7: network: Reset bonding options we did not modify to defaults (WIP) Line 8: Line 9: This is an attempt to have bonds configured with exactly Line 10: the options that were requested. Including blank '' options signifying defaults. Line 11: Line 12: The handling of mode 4 options (if they are options at all?) Line 13: is yet to be investigated. I suspect they also belong to the set Line 14: of run-time values we should not even report as bonding options. http://gerrit.ovirt.org/#/c/26374/6/vdsm/network/models.py File vdsm/network/models.py: Line 192: Line 193: def confOptions(self): Line 194: return [option.split('=', 1) for option in self.options.split(' ')] Line 195: Line 196: def replaceCurrentOptsWithDefaults(self): Here we can see how clumsy the work with defaults options remembered per mode can get. As explained in the comments to the previous patch – http://gerrit.ovirt.org/#/c/24456/20/lib/vdsm/netinfo.py – I strongly suggest using a merged dictionary of defaults. For all modes, the options are exactly the same. Only the mode 4 manifests has a few extra 'options' that I still have yet to learn about. Line 197: ''' Line 198: Any active non-default value not touched by options being currently Line 199: set is added so it is explicitly reset to its default. Line 200: -- To view, visit http://gerrit.ovirt.org/26374 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I884b7436e12df9dc8572694f886a3c7eb32de200 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda <osvob...@redhat.com> Gerrit-Reviewer: Antoni Segura Puimedon <asegu...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Ondřej Svoboda <osvob...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
