Michal Skrivanek has posted comments on this change.

Change subject: virt: Move all guest agents related cleanup together
......................................................................


Patch Set 1: Code-Review-1

(1 comment)

if I'm not missing anything - I think it should be consolidated even more

http://gerrit.ovirt.org/#/c/26280/1/vdsm/virt/vm.py
File vdsm/virt/vm.py:

Line 3074:         """
Line 3075:         self._cleanupDrives()
Line 3076:         self._cleanupFloppy()
Line 3077:         self._cleanupGuestAgents()
Line 3078:         utils.rmFile(self._recoveryFile)
and this one as well...
Line 3079: 
Line 3080:     def updateGuestCpuRunning(self):
Line 3081:         self._guestCpuRunning = (self._dom.info()[0] ==
Line 3082:                                  libvirt.VIR_DOMAIN_RUNNING)


-- 
To view, visit http://gerrit.ovirt.org/26280
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I99da4b5b9dcb160974205ebbb3c6d6727415e617
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Vinzenz Feenstra <vfeen...@redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com>
Gerrit-Reviewer: Francesco Romani <from...@redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skriva...@redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeen...@redhat.com>
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Reply via email to