Francesco Romani has posted comments on this change. Change subject: pep8: hooks cleanups for pep-1.5.x ......................................................................
Patch Set 2: (1 comment) http://gerrit.ovirt.org/#/c/26383/2/vdsm_hooks/fileinject/before_vm_start.py File vdsm_hooks/fileinject/before_vm_start.py: Line 93: rawcount += 1 Line 94: Line 95: # disk format can be raw or qcow2 Line 96: # http://libguestfs.org/guestfs.3.html Line 97: # see: guestfs_add_drive_opts > my pep8-1.5.1 did not cry about a too-long comment if it's only a url. you're right I must have overlooked something. However, fixed. Line 98: path = None Line 99: if source.hasAttribute('file'): Line 100: path = source.attributes['file'].value Line 101: elif source.hasAttribute('dev'): -- To view, visit http://gerrit.ovirt.org/26383 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I18ed1b38dc3bff8b04e26a712f5968184d0391b0 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Antoni Segura Puimedon <asegu...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
