Dan Kenigsberg has submitted this change and it was merged. Change subject: hsm: Do not hide errors when checking device visibility ......................................................................
hsm: Do not hide errors when checking device visibility When checking devices visibility, all errors from os.stat() are treated as "device does not exists", hiding fatal error and making it harder to debug and fix them. This patch handle only ENOENT for checking visibility and raise other errors we cannot handle. Change-Id: I7411d7d2eaa9172f612fd1b1e04177bef270ab19 Relates-To: https://bugzilla.redhat.com/923773 Bug-Url: https://bugzilla.redhat.com/1066413 Signed-off-by: Nir Soffer <[email protected]> Reviewed-on: http://gerrit.ovirt.org/21211 Reviewed-by: Ayal Baron <[email protected]> Reviewed-on: http://gerrit.ovirt.org/25242 Reviewed-by: Allon Mureinik <[email protected]> Reviewed-by: Federico Simoncelli <[email protected]> --- M vdsm/storage/hsm.py 1 file changed, 3 insertions(+), 1 deletion(-) Approvals: Nir Soffer: Verified Federico Simoncelli: Looks good to me, approved Allon Mureinik: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/25242 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7411d7d2eaa9172f612fd1b1e04177bef270ab19 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.3 Gerrit-Owner: Nir Soffer <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: [email protected] _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
