Dan Kenigsberg has posted comments on this change. Change subject: vm: handle missing domains on recovery ......................................................................
Patch Set 6: Code-Review-1 (1 comment) One little comment about a comment. http://gerrit.ovirt.org/#/c/25275/6/vdsm/virt/vm.py File vdsm/virt/vm.py: Line 1935: # behaviors on VM start/destroy, because the tuning can be Line 1936: # done automatically according to its statistical data. Line 1937: self.cif.ksmMonitor.adjust() Line 1938: except Exception as e: Line 1939: # we cannot continue without a libvirt connection handle the comment still mentions the danken-confusing "libvirt connection handle". I think "libvirtDomain object" is more precise. Line 1940: # to avoid state desync or worse split-brain scenarios. Line 1941: if isinstance(e, libvirt.libvirtError) and \ Line 1942: e.get_error_code() == libvirt.VIR_ERR_NO_DOMAIN: Line 1943: raise MissingLibvirtDomainError() -- To view, visit http://gerrit.ovirt.org/25275 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I00ef12883c8035209de0f273925eb8603d6b6da8 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Michal Skrivanek <[email protected]> Gerrit-Reviewer: Vinzenz Feenstra <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
