Dan Kenigsberg has posted comments on this change. Change subject: Explicitly close libvirt connections at exist ......................................................................
Patch Set 3: (1 comment) http://gerrit.ovirt.org/#/c/17192/3/lib/vdsm/libvirtconnection.py File lib/vdsm/libvirtconnection.py: Line 176: def __close_connections(): Line 177: for conn in __connections.values(): Line 178: conn.close() Line 179: Line 180: atexit.register(__close_connections) > +1 for prepareForShutdown (that in theory should already call stop_event_lo I much prefer having this module standalone and usable outside of vdsm proper. I actually noticed the the stray connections causing libvirt errors after running `vdsm-tool dummybr` several times, where there's no prepareForShutdown. Ack for calling stop_event_loop() in http://gerrit.ovirt.org/26532 -- To view, visit http://gerrit.ovirt.org/17192 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2b15f3ab017828a63960ba9311fa2bf6bfab4729 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Itamar Heim <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: Yeela Kaplan <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: mooli tayer <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
