Douglas Schilling Landgraf has posted comments on this change. Change subject: hook: spiceoptions: To provide spice option attributes to vm ......................................................................
Patch Set 8: Code-Review-1 (3 comments) few comments http://gerrit.ovirt.org/#/c/22178/8/vdsm_hooks/spiceoptions/Makefile.am File vdsm_hooks/spiceoptions/Makefile.am: Line 1: # Line 2: # Copyright 2013 Red Hat, Inc. 2014 Line 3: # Line 4: # This program is free software; you can redistribute it and/or modify Line 5: # it under the terms of the GNU General Public License as published by Line 6: # the Free Software Foundation; either version 2 of the License, or Line 18: # Refer to the README and COPYING files for full details of the license Line 19: # Line 20: # Line 21: EXTRA_DIST = \ Line 22: before_vm_start.py tab Line 23: Line 24: install-data-local: Line 25: $(MKDIR_P) $(DESTDIR)$(vdsmhooksdir)/before_vm_start Line 26: $(INSTALL_SCRIPT) $(srcdir)/before_vm_start.py \ http://gerrit.ovirt.org/#/c/22178/8/vdsm_hooks/spiceoptions/before_vm_start.py File vdsm_hooks/spiceoptions/before_vm_start.py: Line 1: #!/usr/bin/python Line 2: Line 3: import os Line 4: import sys Line 5: import hooking (for import hooking) Imports should be grouped in the following order: standard library imports related third party imports local application/library specific imports You should put a blank line between each group of imports. http://legacy.python.org/dev/peps/pep-0008/#imports Line 6: import traceback Line 7: import ast Line 8: from xml.dom import minidom Line 9: -- To view, visit http://gerrit.ovirt.org/22178 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7761aab98cdc3a0d37bed7984ae540278e6bbf70 Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Humble Devassy Chirammal <[email protected]> Gerrit-Reviewer: Amador Pahim <[email protected]> Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Douglas Schilling Landgraf <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Humble Devassy Chirammal <[email protected]> Gerrit-Reviewer: Michal Skrivanek <[email protected]> Gerrit-Reviewer: Timothy Asir <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
