Michal Skrivanek has posted comments on this change.

Change subject: do not use OOP for padding snapshot's memory volume
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.ovirt.org/#/c/26538/1//COMMIT_MSG
Commit Message:

Line 3: AuthorDate: 2014-04-08 13:58:13 +0300
Line 4: Commit:     Arik Hadas <aha...@redhat.com>
Line 5: CommitDate: 2014-04-08 13:58:13 +0300
Line 6: 
Line 7: do not use OOP for padding snapshot's memory volume
> Without oop we have a chance that a single disappearing NFS export moves al
How could it disappear when QEMU just finished writing data to it?

We're not protecting the libvirt call either, btw. 

Anyway, if we do want to cover ourselves in this case as well, OOP would always 
be better, not just for NFS.
Line 8: 
Line 9: Change-Id: I2a94354e188019f3afd209633979ec5a5b35293b


-- 
To view, visit http://gerrit.ovirt.org/26538
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2a94354e188019f3afd209633979ec5a5b35293b
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <aha...@redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimo...@redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skriva...@redhat.com>
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Reply via email to