Dan Kenigsberg has posted comments on this change. Change subject: netlink: User libnl-3 when available ......................................................................
Patch Set 4: Code-Review-1 (1 comment) http://gerrit.ovirt.org/#/c/26514/4//COMMIT_MSG Commit Message: Line 15: Line 16: This change makes it necessary to require newer versions of Line 17: python-ethtool (>= 0.9) since Fedora systems will have libnl3 and Line 18: they could have an older python-ethtool (at release time it was Line 19: 0.8.x). > But python-ethtool >= 0.9.1 is *not* available on Fedora 19, so this patch Right, since what we care about is not the availability of libnl3, but rather the need to know what python-ethtool is using. Too bad that I am not aware of a sane way to check this programmatically, so we'd rely on the version. That would also be safer on other system (el6) where python-ethtool uses libnl1, and the local admin installed libnl3 just for fun. Line 20: Line 21: Change-Id: I45f043a8416e57d5fb550e2e817e6df38cd793b1 Line 22: Bug-Url: https://bugzilla.redhat.com/1078312 -- To view, visit http://gerrit.ovirt.org/26514 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I45f043a8416e57d5fb550e2e817e6df38cd793b1 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon <asegu...@redhat.com> Gerrit-Reviewer: Antoni Segura Puimedon <asegu...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
