Dan Kenigsberg has submitted this change and it was merged. Change subject: recovery: clean the VM recovery procedure ......................................................................
recovery: clean the VM recovery procedure This tiny patch cleans up and optimizes the VM recovery detection. While looping on the VMs returned by libvirt, we must check each one of them to know if it has to be handled by VDSM. This check, however, considers only the properties of the VM under exam, so we can do this in one go instead of using two loops (actually an explicit loop and one implicit in a list comprehension) This patch is not for performance but to to make the code a tiny bit cleaner and to fix this message: ./vdsm/clientIF.py:493: list comprehension redefines 'vm' from line 483 emitted by some versions of pyflakes. Change-Id: Idf09400276d9fcf24a0ad6673ee1d12f19a92195 Signed-off-by: Francesco Romani <[email protected]> Reviewed-on: http://gerrit.ovirt.org/26426 Reviewed-by: Federico Simoncelli <[email protected]> Reviewed-by: Dan Kenigsberg <[email protected]> --- M vdsm/clientIF.py 1 file changed, 3 insertions(+), 2 deletions(-) Approvals: Federico Simoncelli: Looks good to me, but someone else must approve Dan Kenigsberg: Looks good to me, approved Francesco Romani: Verified -- To view, visit http://gerrit.ovirt.org/26426 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Idf09400276d9fcf24a0ad6673ee1d12f19a92195 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani <[email protected]> Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
