Francesco Romani has posted comments on this change. Change subject: tests: virt: retry to connect to VDSM at startup ......................................................................
Patch Set 2: (2 comments) http://gerrit.ovirt.org/#/c/26638/2/tests/functional/utils.py File tests/functional/utils.py: Line 68: from common boilerplate code. Line 69: """ Line 70: Line 71: def __init__(self): Line 72: retry(self.start, (socket.error, KeyError), tries=10) > I'd use more, given the slow jenkins environment….like 30 or even 60 Will switch to 30 for now, and go up if needed (well I actually hope jenkins is not THAT slow) Line 73: Line 74: def start(self): Line 75: self.vdscli = vdscli.connect() Line 76: self.netinfo = \ Line 72: retry(self.start, (socket.error, KeyError), tries=10) Line 73: Line 74: def start(self): Line 75: self.vdscli = vdscli.connect() Line 76: self.netinfo = \ > this originated as network code….but I think it makes more sense to have ju Will fix in a separate patch Line 77: netinfo.NetInfo(self.vdscli.getVdsCapabilities()['info']) Line 78: if config.get('vars', 'net_persistence') == 'unified': Line 79: self.config = RunningConfig() Line 80: else: -- To view, visit http://gerrit.ovirt.org/26638 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic3a6e9e484d7bf0c506b804131b9e958deff5692 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani <[email protected]> Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Michal Skrivanek <[email protected]> Gerrit-Reviewer: Vinzenz Feenstra <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
