Dan Kenigsberg has posted comments on this change. Change subject: pep8: fix pep8 1.5.4/1.5.5 ......................................................................
Patch Set 1: Code-Review-1 (1 comment) http://gerrit.ovirt.org/#/c/26764/1/vdsm/dmidecodeUtil.py File vdsm/dmidecodeUtil.py: Line 95: cache=formatData(d['cache']), Line 96: processor=formatData(d['processor']), Line 97: chassis=formatData(d['chassis']), Line 98: memory=formatData(d['memory'])) Line 99: ) > Maybe we could get rid of the .format and use the old way we have in the re Or a complete rewrite of printInfo, or its utter deletion. Please do this in its own patch - I 'd rather keep both versions quiet. -- To view, visit http://gerrit.ovirt.org/26764 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I34a389df601f24292cd96f48dd8640408ea1da66 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Antoni Segura Puimedon <asegu...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
