Dan Kenigsberg has posted comments on this change. Change subject: net_tests: Move network unit tests into package ......................................................................
Patch Set 1: Code-Review-1 (3 comments) http://gerrit.ovirt.org/#/c/26874/1/tests/network/Makefile.am File tests/network/Makefile.am: Line 30: tcTests.py \ Line 31: $(NULL) Line 32: Line 33: MODULES = \ Line 34: network/apiTests.py \ do we have to repeat this list? Line 35: network/ipwrapperTests.py \ Line 36: network/netconfpersistenceTests.py \ Line 37: network/netconfTests.py \ Line 38: network/netinfoTests.py \ http://gerrit.ovirt.org/#/c/26874/1/tests/run_tests_local.sh.in File tests/run_tests_local.sh.in: Line 1: #!/bin/sh If you have to use a bashism, make it explicit. Line 2: if [ -z "$PYTHON_EXE" ]; then Line 3: PYTHON_EXE="@PYTHON@" Line 4: fi Line 5: Line 2: if [ -z "$PYTHON_EXE" ]; then Line 3: PYTHON_EXE="@PYTHON@" Line 4: fi Line 5: Line 6: # The following line is taken from http://stackoverflow.com/a/246128/206009 attribution is great, but please say what it does - it was not clear to me. also, it's not clear to me why absolute paths are no longer good now. Line 7: DIR="$( cd "$( dirname "${BASH_SOURCE[0]}" )" && pwd )" Line 8: Line 9: if [ ! -f "$DIR/jsonrpc-tests.server.crt" ] || [ ! -f "$DIR/jsonrpc-tests.server.csr" ] || [ ! -f "$DIR/jsonrpc-tests.server.key" ]; then Line 10: $DIR/makecert.sh -- To view, visit http://gerrit.ovirt.org/26874 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6960ce365d67ab4bb0a5475d7957e6117bef7e60 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
