Dan Kenigsberg has posted comments on this change. Change subject: vm: spice support to clipboard copypaste disable ......................................................................
Patch Set 4: Code-Review-1 (2 comments) http://gerrit.ovirt.org/#/c/22646/4//COMMIT_MSG Commit Message: Line 17: Line 18: No XML changes are produced at all unless the new parameter is Line 19: specified. Line 20: Line 21: Bug-Url: https://bugzilla.redhat.com/800155 please make this bug public, and/or link to to https://bugzilla.redhat.com/show_bug.cgi?id=1052959 instead. Line 22: Change-Id: I1f8195da0c3ba2663027b77ea8a858e5ba17c48e http://gerrit.ovirt.org/#/c/22646/4/vdsm/virt/vm.py File vdsm/virt/vm.py: Line 806: <channel type='spicevmc'> Line 807: <target type='virtio' name='com.redhat.spice.0'/> Line 808: </channel> Line 809: Line 810: or these two are not contradictory. the <clipboard> element is simply optional - it's not on the same level of vnc/spice distinction. Line 811: Line 812: <graphics autoport="yes" port="5910" tlsPort="5890" type="spice"> Line 813: <clipboard copypaste='no'/> Line 814: </graphics> -- To view, visit http://gerrit.ovirt.org/22646 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1f8195da0c3ba2663027b77ea8a858e5ba17c48e Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Michal Skrivanek <[email protected]> Gerrit-Reviewer: Saggi Mizrahi <[email protected]> Gerrit-Reviewer: Vinzenz Feenstra <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
