Douglas Schilling Landgraf has posted comments on this change. Change subject: caps: Add selinux enforcement reporting. ......................................................................
Patch Set 1: (3 comments) please verify http://gerrit.ovirt.org/#/c/26951/1//COMMIT_MSG Commit Message: Line 7: caps: Add selinux enforcement reporting. Line 8: Line 9: Added selinuxEnforceModed field to getVdsCaps() what indicates whether Line 10: selinux is enforced on host or not Line 11: > add direct link to engine's part +1 to yaniv's comment and Bug-Url if it has. Line 12: Change-Id: I98e0fcb71e831a76c4584bca46dc58fc4298180f http://gerrit.ovirt.org/#/c/26951/1/vdsm/caps.py File vdsm/caps.py: Line 401: with open(enforce_path) as fileStream: Line 402: return int(fileStream.read().strip()) Line 403: Line 404: # Assume disabled if cannot find Line 405: return -1 > I would add here the comment from /etc/selinux/config: Agree with yaniv, please use docstring format. Line 406: Line 407: Line 408: def get(): Line 409: targetArch = getTargetArch() Line 474: caps['numaNodeDistance'] = _getNumaNodeDistance() Line 475: caps['autoNumaBalancing'] = _getAutoNumaBalancingInfo() Line 476: Line 477: if selinux.is_selinux_enabled() == 0: Line 478: caps['selinuxEnforceMode'] = str(-1) > do we really need selinux package here? isn't getSELinuxEnforceMode enough +1 for Yaniv comment. Line 479: else: Line 480: caps['selinuxEnforceMode'] = getSELinuxEnforceMode() Line 481: return caps Line 482: -- To view, visit http://gerrit.ovirt.org/26951 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I98e0fcb71e831a76c4584bca46dc58fc4298180f Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dima Kuznetsov <dkuzn...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Douglas Schilling Landgraf <dougsl...@redhat.com> Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches