Dan Kenigsberg has posted comments on this change. Change subject: virt: stats: move dynamic stats in a method ......................................................................
Patch Set 3: Code-Review+1 (1 comment) http://gerrit.ovirt.org/#/c/26548/3/vdsm/virt/vm.py File vdsm/virt/vm.py: Line 2483: stats['exitReason'] = self.conf['exitReason'] Line 2484: if 'timeOffset' in self.conf: Line 2485: stats['timeOffset'] = self.conf['timeOffset'] Line 2486: Line 2487: def _addDynamicVmStats(self, stats): the juridcition of this method is not very clear, but I do not mind making this change. Line 2488: decStats = {} Line 2489: try: Line 2490: if self._vmStats: Line 2491: decStats = self._vmStats.get() -- To view, visit http://gerrit.ovirt.org/26548 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5a2b7658c209a3dcdd6df46052440204ad52a5d3 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
