Dan Kenigsberg has posted comments on this change.

Change subject: virt: graphdev: introduce the GraphicsDevice class
......................................................................


Patch Set 5:

(1 comment)

http://gerrit.ovirt.org/#/c/26894/5/vdsm/virt/vm.py
File vdsm/virt/vm.py:

Line 1379:     LIBVIRT_PORT_AUTOSELECT = '-1'
Line 1380: 
Line 1381:     @staticmethod
Line 1382:     def isSupportedDisplayType(vmParams):
Line 1383:         return vmParams.get('display') in ('vnc', 'qxl', 'qxlnc')
didn't you tell Michal you'd need to add "spice" to the tuple? or is it 
expected in a future patch?
Line 1384: 
Line 1385:     @staticmethod
Line 1386:     def adjustDisplayParams(dispParams, displayIp):
Line 1387:         """


-- 
To view, visit http://gerrit.ovirt.org/26894
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic4f8e527fd48d8635b61cdc14eed31b8992e4f6c
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Francesco Romani <[email protected]>
Gerrit-Reviewer: Frank Kobzik <[email protected]>
Gerrit-Reviewer: Martin Polednik <[email protected]>
Gerrit-Reviewer: Michal Skrivanek <[email protected]>
Gerrit-Reviewer: Vinzenz Feenstra <[email protected]>
Gerrit-Reviewer: [email protected]
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Reply via email to