mooli tayer has posted comments on this change. Change subject: Adding remove/disable verbs to vdsm-tool for admin usages ......................................................................
Patch Set 15: (2 comments) http://gerrit.ovirt.org/#/c/21772/15/lib/vdsm/tool/passwd.py File lib/vdsm/tool/passwd.py: Line 53: Remove vdsm password for libvirt connection Line 54: """ Line 55: rc, out, err = utils.execCmd( Line 56: (constants.EXT_SASLPASSWD2, '-p', '-a', 'libvirt', Line 57: '-d', constants.SASL_USERNAME,), > please consider to indent: Yes it is better. Line 58: ) Line 59: if rc != 0: Line 56: (constants.EXT_SASLPASSWD2, '-p', '-a', 'libvirt', Line 57: '-d', constants.SASL_USERNAME,), Line 58: ) Line 59: if rc != 0: Line 60: raise RuntimeError("Remove password failed: %s" % (err,)) > % err is sufficient. I believe vdsm style usually uses tuple in such cases in preparation to other variables. -- To view, visit http://gerrit.ovirt.org/21772 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie7f2c031436a6d202f856c24d9c9420c8bfdf6df Gerrit-PatchSet: 15 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: mooli tayer <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
