Dan Kenigsberg has posted comments on this change.

Change subject: virt: graphdev: switch to the GraphicsDevice class
......................................................................


Patch Set 7:

(2 comments)

http://gerrit.ovirt.org/#/c/26895/7/vdsm/virt/vm.py
File vdsm/virt/vm.py:

Line 1818:             devices[VIDEO_DEVICES] = self.getConfVideo()
Line 1819:             devices[GRAPHICS_DEVICES] = self.getConfGraphics()
Line 1820:             devices[CONTROLLER_DEVICES] = self.getConfController()
Line 1821:         else:
Line 1822:             # ensure backward compatibility
I do not understand this comment.
Line 1823:             derivedGraphics = self.__legacyGraphics()
Line 1824:             if derivedGraphics:
Line 1825:                 self.conf['devices'].append(derivedGraphics)
Line 1826: 


Line 1919:                 'type': GRAPHICS_DEVICES,
Line 1920:                 'device': 'spice',
Line 1921:                 'specParams': {
Line 1922:                     'port': GraphicsDevice.LIBVIRT_PORT_AUTOSELECT}}
Line 1923:         # else already normalized by adjustDisplayParams
I am confused: we have adjustDisplayParams, __legacyGraphics, and 
getConfGraphics
Line 1924:         return [graph]
Line 1925: 
Line 1926:     def getConfSound(self):
Line 1927:         """


-- 
To view, visit http://gerrit.ovirt.org/26895
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I82e4414aa3efe7c756ba8ef9b7b47e591613a717
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Francesco Romani <[email protected]>
Gerrit-Reviewer: Frank Kobzik <[email protected]>
Gerrit-Reviewer: Martin Polednik <[email protected]>
Gerrit-Reviewer: Michal Skrivanek <[email protected]>
Gerrit-Reviewer: Vinzenz Feenstra <[email protected]>
Gerrit-Reviewer: [email protected]
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Reply via email to