Yaniv Bronhaim has posted comments on this change. Change subject: oop: Add an option to configure oop implementation ......................................................................
Patch Set 6: (4 comments) http://gerrit.ovirt.org/#/c/26576/6/vdsm.spec.in File vdsm.spec.in: Line 72: BuildRequires: python-pthreading Line 73: BuildRequires: python-cpopen >= 1.3 Line 74: BuildRequires: rpm-python Line 75: BuildRequires: python-ioprocess >= 0.3 Line 76: BuildRequires: libnl if we still can choose between that and the old rfh, why is it hard requirement ? btw, is it available already in rhel and fedora repos? guess not, so i would state it until it will Line 77: BuildRequires: libselinux-python Line 78: BuildRequires: libvirt-python Line 79: BuildRequires: genisoimage Line 80: BuildRequires: openssl http://gerrit.ovirt.org/#/c/26576/6/vdsm/storage/hsm.py File vdsm/storage/hsm.py: Line 359: Line 360: self.__validateLvmLockingType() Line 361: Line 362: oop.setDefaultImpl(config.get('irs', 'oop_impl')) Line 363: read it in outOfProcess.py, don't think we need more places to set the default during run time Line 364: self.domainStateChangeCallbacks = set() Line 365: Line 366: # cleanStorageRepoitory uses tasksDir value, this must be assigned Line 367: # before calling it http://gerrit.ovirt.org/#/c/26576/6/vdsm/storage/outOfProcess.py File vdsm/storage/outOfProcess.py: Line 28: from remoteFileHandler import RemoteFileHandlerPool Line 29: Line 30: RFH = 'rfh' Line 31: IOPROC = 'ioprocess' Line 32: OOP_IMPL = RFH shouldn't it be the value from config oop_impl? Line 33: Line 34: DEFAULT_TIMEOUT = config.getint("irs", "process_pool_timeout") Line 35: HELPERS_PER_DOMAIN = config.getint("irs", "process_pool_max_slots_per_domain") Line 36: Line 41: Line 42: def setDefaultImpl(impl): Line 43: global OOP_IMPL Line 44: OOP_IMPL = impl Line 45: why do you need that? ^ Line 46: Line 47: def getProcessPool(clientName): Line 48: try: Line 49: return _proc[clientName][OOP_IMPL] -- To view, visit http://gerrit.ovirt.org/26576 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibd756afd43d23631dc7ed4bac64bec9a81b358b4 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yeela Kaplan <ykap...@redhat.com> Gerrit-Reviewer: Barak Azulay <bazu...@redhat.com> Gerrit-Reviewer: Federico Simoncelli <fsimo...@redhat.com> Gerrit-Reviewer: Saggi Mizrahi <smizr...@redhat.com> Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com> Gerrit-Reviewer: Yeela Kaplan <ykap...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
