Dan Kenigsberg has posted comments on this change.

Change subject: Unknown dmidecode value is set to None which cannot be parsed 
by xmlrpc
......................................................................


Patch Set 2: Code-Review-1

(1 comment)

http://gerrit.ovirt.org/#/c/26942/2/vdsm/dmidecodeUtil.py
File vdsm/dmidecodeUtil.py:

Line 30:     ret = {}
Line 31:     for k, v in d.iteritems():
Line 32:         if isinstance(v, dict):
Line 33:             ret.update(__leafDict(v))
Line 34:         else:
elif v is not None
Line 35:             ret[k] = 'Not Specified' if v is None else v
Line 36:     return ret
Line 37: 
Line 38: 


-- 
To view, visit http://gerrit.ovirt.org/26942
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I979518e1d0c0c882fe98fd5aee43c0d50ab17e14
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Yaniv Bronhaim <[email protected]>
Gerrit-Reviewer: [email protected]
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Reply via email to