Yaniv Bronhaim has submitted this change and it was merged. Change subject: vm: consider 'action' when handling I/O errors ......................................................................
vm: consider 'action' when handling I/O errors When VDSM receives an I/O error event from libvirt, it does not consider the value of the 'action' callback field, and thus considers the guest CPU stopped. This is true in the default configuration, which translates to the disk write error policy 'stop', but not necessarily true if the said policy is 'enospace'. In this case the reported state of the CPU goes out of sync. Since the error policy may be changed through an hook, the safest thing to do is actually check the 'action' value as reported by libvirt in the IOError callback. This patch adds this check, and additional logging in the case the guest CPU is reported running after I/O errors. Change-Id: I9299399c3e5bef7e6e3111aa35e3483827ad57da Bug-Url: https://bugzilla.redhat.com/1090079 Signed-off-by: Francesco Romani <from...@redhat.com> Reviewed-on: http://gerrit.ovirt.org/25157 Reviewed-by: Dan Kenigsberg <dan...@redhat.com> Tested-by: Dan Kenigsberg <dan...@redhat.com> Reviewed-on: http://gerrit.ovirt.org/27016 Reviewed-by: Michal Skrivanek <michal.skriva...@redhat.com> --- M vdsm/clientIF.py M vdsm/vm.py 2 files changed, 17 insertions(+), 9 deletions(-) Approvals: Dan Kenigsberg: Looks good to me, approved Francesco Romani: Verified Michal Skrivanek: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/27016 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9299399c3e5bef7e6e3111aa35e3483827ad57da Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.3 Gerrit-Owner: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skriva...@redhat.com> Gerrit-Reviewer: Vinzenz Feenstra <vfeen...@redhat.com> Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
