Francesco Romani has posted comments on this change.

Change subject: virt: graphdev: support multiple graphics devices
......................................................................


Patch Set 5:

(1 comment)

Patch set 5: enhanced commit message, added better explanations.

http://gerrit.ovirt.org/#/c/27215/5/vdsm_api/vdsmapi-schema.json
File vdsm_api/vdsmapi-schema.json:

Line 6042:           'disksUsage': ['GuestMountInfo'],
Line 6043:           'netIfaces': ['GuestNetworkDeviceInfo'],
Line 6044:           '*watchdogEvent': 'WatchdogEvent', 'guestFQDN': 'str',
Line 6045:           '*migrationProgress': 'uint', 'guestCPUCount': 'int',
Line 6046:           'graphicDevices': ['GraphicsDeviceInfo']}}
I find this approach clearer than the proposal in 
http://www.ovirt.org/Features/Multiple_Consoles

In the longer term, when we are allowed to break comaptibility (4.x) I'd like 
to get rid of the display* fields here and to have only the informations in 
graphicDevices.

That said, I am ok (I like it less but I can live with this)
the additionalDisplayPort field if turns out it is better or simpler.
Line 6047: 
Line 6048: ##
Line 6049: # @VmStats:
Line 6050: #


-- 
To view, visit http://gerrit.ovirt.org/27215
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5be348b342359d42c878937dca27454fe206a35a
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <[email protected]>
Gerrit-Reviewer: Francesco Romani <[email protected]>
Gerrit-Reviewer: [email protected]
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Reply via email to