Dima Kuznetsov has posted comments on this change. Change subject: hooks: Add hook for fake VM stats ......................................................................
Patch Set 15: (2 comments) http://gerrit.ovirt.org/#/c/25927/15/vdsm/vdsmd.8.in File vdsm/vdsmd.8.in: Line 147: after_get_vm_stats and after_get_all_vm_stats are called upon getVmStats and Line 148: getAllVmStats respectively. Both receive a parameter in _hook_json. Line 149: after_get_vm_stats receives a dictionary of the VM stats: Line 150: .nf Line 151: {"vm_id": "...", ... } > please have this hook receive the same type as after_get_all_vm_stats - a l ok Line 152: .fi Line 153: after_get_all_vm_stats receives a list of the above dictionaries: Line 154: .nf Line 155: [ http://gerrit.ovirt.org/#/c/25927/15/vdsm_hooks/fakevmstats/Makefile.am File vdsm_hooks/fakevmstats/Makefile.am: Line 23: CLEANFILES = \ Line 24: config.log Line 25: Line 26: EXTRA_DIST = \ Line 27: after_get_all_vm_stats.py > the added indentation seems funny. ok Line 28: Line 29: install-data-local: Line 30: $(MKDIR_P) $(DESTDIR)$(vdsmhooksdir)/after_get_vm_stats Line 31: $(MKDIR_P) $(DESTDIR)$(vdsmhooksdir)/before_get_vm_stats -- To view, visit http://gerrit.ovirt.org/25927 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6a6d13f43495170a5cb86ae0b0efc1ae85ef05ab Gerrit-PatchSet: 15 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dima Kuznetsov <dkuzn...@redhat.com> Gerrit-Reviewer: Antoni Segura Puimedon <asegu...@redhat.com> Gerrit-Reviewer: Barak Azulay <bazu...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Dima Kuznetsov <dkuzn...@redhat.com> Gerrit-Reviewer: Douglas Schilling Landgraf <dougsl...@redhat.com> Gerrit-Reviewer: Federico Simoncelli <fsimo...@redhat.com> Gerrit-Reviewer: Saggi Mizrahi <smizr...@redhat.com> Gerrit-Reviewer: Vinzenz Feenstra <vfeen...@redhat.com> Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: mooli tayer <mta...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
